CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

• Pre-merge author checklist has unchecked items (e.g. "I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors."). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

🧪 Flaky unit test detection

Run history flaky detection

View recent run history

Historical failure rate is a hint, not proof — review each suggestion in context. See the flaky-test-detection skill for the full pattern reference and manual audit workflow.

Failures / runs sampled per window:

AI-detected flaky patterns

app/components/UI/ActivityListItemRow/ActivityListItemRow.test.tsx

• J3 — Missing jest.clearAllMocks() / jest.resetAllMocks() (high)
  • The 'display currency conversion' describe block restores specific mock return values in afterEach but never calls jest.clearAllMocks(). This means call counts for mockCurrency, mockConversionRate, and mockUsdConversionRate accumulate across every test in this block. If any future test in this file or a sibling describe block asserts toHaveBeenCalledTimes(N) on these selectors, it will see a higher count than expected and fail intermittently depending on test execution order. Additionally, if a test throws mid-body after calling mockCurrency.mockReturnValue('eur'), the afterEach still runs and resets the return value — but the call count from the failed test is never cleared, leaving stale state for subsequent tests. The outer 'row content' describe has jest.clearAllMocks() in beforeEach, but this inner describe does not inherit that guard.
  • Suggested fix in app/components/UI/ActivityListItemRow/ActivityListItemRow.test.tsx:1:

    -describe('ActivityListItemRow — display currency conversion', () => {
    -  const mockCurrency = jest.mocked(selectCurrentCurrency);
    -  const mockConversionRate = jest.mocked(selectConversionRateByChainId);
    -  const mockUsdConversionRate = jest.mocked(selectUSDConversionRateByChainId);
    -  afterEach(() => {
    -    mockCurrency.mockReturnValue('usd');
    -    mockConversionRate.mockReturnValue(2500);
    -    mockUsdConversionRate.mockReturnValue(2500);
    -  });
    +describe('ActivityListItemRow — display currency conversion', () => {
    +  const mockCurrency = jest.mocked(selectCurrentCurrency);
    +  const mockConversionRate = jest.mocked(selectConversionRateByChainId);
    +  const mockUsdConversionRate = jest.mocked(selectUSDConversionRateByChainId);
    +  beforeEach(() => {
    +    jest.clearAllMocks();
    +    mockCurrency.mockReturnValue('usd');
    +    mockConversionRate.mockReturnValue(2500);
    +    mockUsdConversionRate.mockReturnValue(2500);
    +  });
    +  afterEach(() => {
    +    jest.clearAllMocks();
    +  });

• J3 — Missing jest.clearAllMocks() / jest.resetAllMocks() (high)
  • The 'ERC-20 fiat address casing' describe block uses afterEach to restore only mockContractExchangeRates to a specific return value, but never calls jest.clearAllMocks(). Call counts for mockContractExchangeRates accumulate across tests in this block. If a test in this block sets mockContractExchangeRates.mockReturnValue(ratesFor(USDC_CHECKSUM)) and then a subsequent test (or a test in a later describe block that runs after this one) checks toHaveBeenCalledTimes, it will see inflated counts. The missing clearAllMocks also means that any other mocks touched inside these tests (e.g. getNetworkImageSource, useTokensData) retain their call history across tests in this block, creating order-dependent failures.
  • Suggested fix in app/components/UI/ActivityListItemRow/ActivityListItemRow.test.tsx:1:

    -describe('ActivityListItemRow — ERC-20 fiat address casing (TMCU-937)', () => {
    -  const mockContractExchangeRates = jest.mocked(
    -    selectContractExchangeRatesByChainId,
    -  );
    -  const USDC_LOWER = '0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48';
    -  const USDC_CHECKSUM = '0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48';
    -  const ratesFor = (address: string) =>
    -    ({ [address]: { price: 0.0004 } }) as ReturnType<
    -      typeof selectContractExchangeRatesByChainId
    -    >;
    -  afterEach(() => {
    -    mockContractExchangeRates.mockReturnValue(ratesFor(LINEA_MUSD_ADDRESS));
    -  });
    +describe('ActivityListItemRow — ERC-20 fiat address casing (TMCU-937)', () => {
    +  const mockContractExchangeRates = jest.mocked(
    +    selectContractExchangeRatesByChainId,
    +  );
    +  const USDC_LOWER = '0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48';
    +  const USDC_CHECKSUM = '0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48';
    +  const ratesFor = (address: string) =>
    +    ({ [address]: { price: 0.0004 } }) as ReturnType<
    +      typeof selectContractExchangeRatesByChainId
    +    >;
    +  beforeEach(() => {
    +    jest.clearAllMocks();
    +    mockContractExchangeRates.mockReturnValue(ratesFor(LINEA_MUSD_ADDRESS));
    +  });
    +  afterEach(() => {
    +    jest.clearAllMocks();
    +  });

app/util/navigation/navigateToActivityAfterConfirmation.test.tsx

• J1 — async callback without act() wrapping a state update (high)
  • In all three integration tests (flows 1, 2, 3), fireEvent.press triggers navigateToActivityAfterConfirmation, which calls dispatch(StackActions.replace(...)) or navigate(...) on the React Navigation state. Although fireEvent wraps the press in a synchronous act(), React Navigation's internal state reconciliation after a dispatch can schedule additional asynchronous React state updates (re-renders, context propagation). The assertions on focusedRouteName(ref) and rootRouteNames(ref) are made immediately after the press without an await act(async () => {}) guard, so they may read stale navigation state before the update has flushed — causing intermittent failures under load. The author already uses act(() => { ref.goBack(); }) for the subsequent back-navigation step, showing awareness of the pattern; the same guard is needed around the initial press. The same issue exists in flows 2 (line ~168) and 3 (line ~207).
  • Suggested fix in app/util/navigation/navigateToActivityAfterConfirmation.test.tsx:131:

    -    fireEvent.press(getByTestId('redirect-trigger'));
    -
    -    // Whole StakeScreens flow stack replaced (its nested build screen goes too).
    -    expect(focusedRouteName(ref)).toBe(Routes.TRANSACTIONS_VIEW);
    -    expect(rootRouteNames(ref)).toEqual([
    -      Routes.HOME_TABS,
    -      Routes.TRANSACTIONS_VIEW,
    -    ]);
    -
    -    // Back returns to Wallet home, not the consumed confirmation.
    -    act(() => {
    -      ref.goBack();
    -    });
    -    expect(focusedRouteName(ref)).toBe(Routes.HOME_TABS);
    +    await act(async () => {
    +      fireEvent.press(getByTestId('redirect-trigger'));
    +    });
    +
    +    // Whole StakeScreens flow stack replaced (its nested build screen goes too).
    +    expect(focusedRouteName(ref)).toBe(Routes.TRANSACTIONS_VIEW);
    +    expect(rootRouteNames(ref)).toEqual([
    +      Routes.HOME_TABS,
    +      Routes.TRANSACTIONS_VIEW,
    +    ]);
    +
    +    // Back returns to Wallet home, not the consumed confirmation.
    +    act(() => {
    +      ref.goBack();
    +    });
    +    expect(focusedRouteName(ref)).toBe(Routes.HOME_TABS);

This check is informational only and does not block merging.

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeConfirmations, SmokeStake, SmokeSwap, SmokeWalletPlatform, SmokeMoney
• Selected Performance tags: None (no tests recommended)
• Risk Level: high
• AI Confidence: 88%

View GitHub Actions results

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud